Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send invite message as bot message, not ephemeral #607

Merged
merged 5 commits into from
Apr 17, 2024

Conversation

sbishel
Copy link
Member

@sbishel sbishel commented Apr 17, 2024

Summary

Invite messages need to be send from bot, but not as ephemeral messages.

Ticket Link

@sbishel sbishel marked this pull request as ready for review April 17, 2024 21:28
server/api.go Outdated Show resolved Hide resolved
server/connect.go Outdated Show resolved Hide resolved
@calebroseland calebroseland added this to the v1.12 milestone Apr 17, 2024
@calebroseland calebroseland self-requested a review April 17, 2024 22:02
@mgdelacroix mgdelacroix self-requested a review April 17, 2024 22:14
Copy link
Member

@calebroseland calebroseland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working beautifully

CleanShot.2024-04-17.at.17.19.01.mp4

Copy link
Member

@mgdelacroix mgdelacroix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@mgdelacroix mgdelacroix merged commit 9c70367 into main Apr 17, 2024
7 checks passed
@mgdelacroix mgdelacroix deleted the fix-invite-message branch April 17, 2024 22:36
sbishel added a commit that referenced this pull request Apr 17, 2024
* send invite message as bot message, not ephemeral

* update connect message

* check error

* cleanup

* edit post message to not set id

(cherry picked from commit 9c70367)
sbishel added a commit that referenced this pull request Apr 17, 2024
* send invite message as bot message, not ephemeral

* update connect message

* check error

* cleanup

* edit post message to not set id

(cherry picked from commit 9c70367)
sbishel added a commit that referenced this pull request Apr 18, 2024
* send invite message as bot message, not ephemeral

* update connect message

* check error

* cleanup

* edit post message to not set id

(cherry picked from commit 9c70367)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants