[MM-58155] Separate DM/GM option #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulienTant
added
2: Dev Review
lindy65
approved these changes
May 8, 2024
There was a problem hiding this comment.
Thanks @JulienTant - I've QA deferred and we'll test this at a bug bash after merge
lindy65
added
QA/Deferred
sbishel
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR separates the "Enable DM/GM" option into "Enable DM" + "Enable GM", with all the supporting code.
Idea behind how it's done
I kept the same code path mostly because, at least for now, we are treating DMs and GMs the same way.
I renamed a lot of
isDirectMessagetoisDirectOrGroupMessageto make it clearer that it could be both now that there are two options.Though/questions
We do have a tag
is_directin a lot of our prometheus metrics, not quite sure if we should rename those, OR only set to true if the message is an actual DM (exclude GM from this tag). ANd do we add ais_gmtag?Demo
Video of the PR in action:
2024-05-08.09-26-08.mp4
Ticket Link
https://mattermost.atlassian.net/browse/MM-58155