Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MM-58134- Disconnect should not be ephemeral message #648

Merged
merged 2 commits into from
May 15, 2024
Merged

MM-58134- Disconnect should not be ephemeral message #648

merged 2 commits into from
May 15, 2024

Conversation

sbishel
Copy link
Member

@sbishel sbishel commented May 13, 2024

Summary

Creates a new function to send a "connect" message as either ephemeral or non-ephemeral

Ticket Link

Fixes https://mattermost.atlassian.net/browse/MM-58134

@sbishel sbishel added 2: Dev Review Requires review by a core committer QA/Deferred Agreement with QA that these changes will be tested post-merge labels May 14, 2024
@sbishel sbishel marked this pull request as ready for review May 14, 2024 20:31
lieut-data
lieut-data approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@lieut-data lieut-data left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Hopefully my pending hooks test rework will allow us to test this.

lindy65
lindy65 approved these changes May 15, 2024
View reviewed changes
Copy link

@lindy65 lindy65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sbishel - this can be tested post merge

@lindy65 lindy65 added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels May 15, 2024
@sbishel sbishel merged commit 1292481 into main May 15, 2024
7 checks passed
@sbishel sbishel deleted the MM58134-non-ephemeral-message branch May 15, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lieut-data lieut-data lieut-data approved these changes

@calebroseland calebroseland calebroseland approved these changes

@lindy65 lindy65 lindy65 approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request QA/Deferred Agreement with QA that these changes will be tested post-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sbishel @lieut-data @calebroseland @lindy65