upgrade and placate golangci-lint #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lieut-data
commented
Sep 19, 2024
| @@ -802,7 +821,7 @@ func (s *SQLStore) getActiveUsersCount(db sq.BaseRunner, dur time.Duration) (act | |||
|
|
|||
| //db:withReplica | |||
| func (s *SQLStore) getConnectedUsers(db sq.BaseRunner, page, perPage int) ([]*storemodels.ConnectedUser, error) { | |||
| query := s.getQueryBuilder(db).Select("mmuserid, msteamsuserid, Users.FirstName, Users.LastName, Users.Email").From(usersTableName).LeftJoin("Users ON Users.Id = msteamssync_users.mmuserid").Where(sq.NotEq{"token": ""}).OrderBy("Users.FirstName").Offset(uint64(page * perPage)).Limit(uint64(perPage)) | |||
| query := s.getQueryBuilder(db).Select("mmuserid, msteamsuserid, Users.FirstName, Users.LastName, Users.Email").From(usersTableName).LeftJoin("Users ON Users.Id = msteamssync_users.mmuserid").Where(sq.NotEq{"token": ""}).OrderBy("Users.FirstName").Offset(offset(page, perPage)).Limit(limit(perPage)) | |||
There was a problem hiding this comment.
Prior to this change, gosec was reporting:
G115: integer overflow conversion int -> uint64
Open to suggestions on handling this more cleanly!
agnivade
approved these changes
Sep 20, 2024
|
We also need to do this on the server side. |
isacikgoz
approved these changes
Sep 20, 2024
| @@ -54,6 +54,25 @@ func New(db, replica *sql.DB, api plugin.API, encryptionKey func() []byte) *SQLS | |||
| } | |||
| } | |||
|
|
|||
| // offset is a helper function to make golangci-lint happy. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After a Go upgrade, I ran into issues with
golangci-lint, which in tun required upgrading that tooling.Ticket Link
None.