Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial support for adaptive cards #749

Merged
merged 5 commits into from
Sep 30, 2024

Conversation

lieut-data
Copy link
Member

Summary

The goal of this PR is to extract the text blocks from bot messages like these:

image

I can't currently test this "live", but have managed to extract the raw application/vnd.microsoft.card.adaptive and write unit tests that extract and render the text inside. We'll test this on Hub with the Albert bot once merged, tested, and pushed to the private beta marketplace.

Ticket Link

Fixes: https://mattermost.atlassian.net/browse/MM-60608

@lieut-data lieut-data marked this pull request as ready for review September 23, 2024 19:07
@lieut-data lieut-data requested a review from sbishel September 23, 2024 19:08
@lieut-data lieut-data added the 2: Dev Review Requires review by a core committer label Sep 23, 2024
@lieut-data
Copy link
Member Author

cc @DSchalla, re: Albert.

Copy link
Member

@mgdelacroix mgdelacroix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

server/attachments.go Outdated Show resolved Hide resolved
@mgdelacroix mgdelacroix added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Sep 27, 2024
lieut-data and others added 2 commits September 27, 2024 14:32
Co-authored-by: Miguel de la Cruz <miguel@mcrx.me>
@lieut-data lieut-data merged commit 81406a1 into main Sep 30, 2024
9 checks passed
@lieut-data lieut-data deleted the initial-support-for-adaptive-cards branch September 30, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants