Added new team filter customisation options #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshilsharma63
added
1: UX Review
harshilsharma63
requested review from
marianunez,
hmhealey,
abhijit-singh and
esarafianou
|
Thanks @harshilsharma63. Can you put this on a test server? |
marianunez
approved these changes
Jul 18, 2024
abhijit-singh
approved these changes
Jul 19, 2024
There was a problem hiding this comment.
Looks perfect functionally @harshilsharma63.
A couple of small things:
- The radio button and label seem to be sticking to each other right now. There should be 8px of space between them.
- There is a slightly weird jumping behaviour when switching from
Send to everyoneand any of the other options. I was expecting everything below it to move up instead of redistributing the space between the fields. But I think that's difficult because we need to keep the total container height constant for the collapsing functionality so it is okay to keep this as is.
https://github.com/user-attachments/assets/43d1101c-a91d-4544-be55-fc58e641e980
|
@abhijit-singh I've fixed those those UI now and have updated the plugin on test server. |
|
Thanks @harshilsharma63! Looks good! Just one more tiny thing that I noticed today — the field label is not aligned with the first radio button. We can add a margin of 9px above the input options to align them. 
|
|
@abhijit-singh done. |
hmhealey
approved these changes
Jul 22, 2024
server/store/migrations/000014_survey_table_add_team_filter_type_column.up.sql
Outdated
Show resolved
Hide resolved
esarafianou
approved these changes
Jul 24, 2024
harshilsharma63
removed
1: UX Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added more control to how team filters work.
Ticket Link
Fixes - https://mattermost.atlassian.net/browse/MM-59564