Removed redundant mutex from migration and used MM migration timeout setting for plugin migration timeout #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshilsharma63
added
2: Dev Review
larkox
approved these changes
Jul 23, 2024
|
@harshilsharma63 I skimmed through the code and there are no security related changes. No need from a proper review from us. |
hmhealey
approved these changes
Jul 25, 2024
hmhealey
added
3: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Applied following changes to migration code-
morph.WithLock()function which we're already using.Ticket Link
Fixes https://mattermost.atlassian.net/browse/MM-59845