This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Migrate get link modal to be pure and use Redux #228
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@saturninoabril Here is the PR. I'm stuck at getting the tests passed because of some unsupported DOM API by jsdom, namely Related issues on jsdom:
Another finding is using the |
jasonblais
added
2: Dev Review
Requires review by a core commiter
Work in Progress
Not yet ready for review
and removed
2: Dev Review
Requires review by a core commiter
labels
Nov 1, 2017
saturninoabril
force-pushed
the
GH-7679
branch
from
November 6, 2017 21:30
3758806
to
3ab8bfa
Compare
@tkbky I've found a workaround, on mocking like:
Also added/modified some tests. |
saturninoabril
added
2: Dev Review
Requires review by a core commiter
and removed
Work in Progress
Not yet ready for review
labels
Nov 6, 2017
saturninoabril
approved these changes
Nov 6, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks!
@saturninoabril That looks great! Thanks for making the PR way better. 😄 |
tkbky
changed the title
[WIP] Migrate get link modal to be pure and use Redux
Migrate get link modal to be pure and use Redux
Nov 7, 2017
jwilander
approved these changes
Nov 7, 2017
jwilander
added
4: Reviews Complete
All reviewers have approved the pull request
and removed
2: Dev Review
Requires review by a core commiter
labels
Nov 7, 2017
Awesome, thanks @tkbky |
jasonblais
added
Changelog/Not Needed
Does not require a changelog entry
Docs/Not Needed
Does not require documentation
labels
Jan 4, 2018
hmhealey
pushed a commit
that referenced
this pull request
Aug 28, 2020
hmhealey
pushed a commit
that referenced
this pull request
Mar 17, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
4: Reviews Complete
All reviewers have approved the pull request
Changelog/Not Needed
Does not require a changelog entry
Docs/Not Needed
Does not require documentation
Hacktoberfest
Tests/Not Needed
Does not require new release tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrate get link modal to be pure and use Redux.
Ticket Link
mattermost-server/issues/7679
Checklist