This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
GH-7680 Migrate get post link modal to be pure #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, this is my first try to work on the webapp, let me know if there is any problem. |
|
Great, thanks @h2oloopan! Looks like the build fails, can you take a look at it? If you're not sure why, let us know and we can help out |
|
Hmm, I can't check details on GitHub. I will see if the build problem occurs on my local machine when I get home. On the other hand, can you help me post the error log from the build server here so I can take a look at it first? Thanks! |
|
Looks like the build suddenly stopped halfway through for no reason. Re-running it |
|
You've got this style error: |
…migrate-get-post-link-modal
|
Was travelling on the weekend. Finally got back home and setup eslint on my local machine. The semicolons should have been fixed now. |
|
@h2oloopan Thank you for your contribution! |
|
@saturninoabril Thanks for the added test! |
jwilander
approved these changes
Nov 7, 2017
jwilander
added
4: Reviews Complete
|
Thanks for this @h2oloopan ! |
jasonblais
added
Changelog/Not Needed
hmhealey
pushed a commit
that referenced
this pull request
Aug 28, 2020
* only set fetch's credentials:include option if no access token this is what client.js does, and fixes a CORS issue when running client4.js in a browser. Specifically, the issue seen is: Fetch API cannot load http://127.0.0.1:8065/api/v4/users/me. Response to preflight request doesn't pass access control check: The value of the 'Access-Control-Allow-Credentials' header in the response is '' which must be 'true' when the request's credentials mode is 'include'. Origin 'http://127.0.0.1:8002' is therefore not allowed access. * Revert "only set fetch's credentials:include option if no access token" This reverts commit 2ba1306a69e46f84a7143c2ce2753a1f222cb118. * make sending credentials via fetch configurable in client4.js this preserves the default behaviour of sending cookies as part of the request, but can be turned off with client.setIncludeCookes(false).
hmhealey
pushed a commit
that referenced
this pull request
Mar 17, 2021
* only set fetch's credentials:include option if no access token this is what client.js does, and fixes a CORS issue when running client4.js in a browser. Specifically, the issue seen is: Fetch API cannot load http://127.0.0.1:8065/api/v4/users/me. Response to preflight request doesn't pass access control check: The value of the 'Access-Control-Allow-Credentials' header in the response is '' which must be 'true' when the request's credentials mode is 'include'. Origin 'http://127.0.0.1:8002' is therefore not allowed access. * Revert "only set fetch's credentials:include option if no access token" This reverts commit 2ba1306a69e46f84a7143c2ce2753a1f222cb118. * make sending credentials via fetch configurable in client4.js this preserves the default behaviour of sending cookies as part of the request, but can be turned off with client.setIncludeCookes(false).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrated get post link modal to be a pure component and use Redux.
No store or action is involved
Ticket Link
mattermost/mattermost#7680
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]