[MM-61426] Migrate to pion v4 #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
streamer45
added
2: Dev Review
cpoile
approved these changes
Nov 1, 2024
cpoile
added
3: Reviews Complete
|
This will take longer as there's another regression with how we track metrics for outgoing tracks due to how the connection closing logic changed. |
|
Load tests look good. I'll merge this soon. |
streamer45
removed
the
Do Not Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR migrates to the new
pion/webrtcv4 and related dependencies.Of note, I conducted a quick load test to ensure performance was on par, and it didn't go as expected (20-30% worse). After some digging, I discovered the issue being on the client side, meaning the updated client is now sending significantly more (one order of magnitude) RTCP messages (twcc especially), which are causing additional load on the server. Disabling that interceptor brings the performance back to the expected level.
What this means is that the server performs equally (less than 5% variance) when load-tested by a non-updated client. I'll need to review this separately because I don't yet know how this new client behaviour compares to a real client (e.g. web browser) (https://mattermost.atlassian.net/browse/MM-61476) but the backend update can proceed.
Ticket Link
https://mattermost.atlassian.net/browse/MM-61426