Duplicate libraries when same lib used by multiple packages in one wheel #35
Labels
Comments
matthew-brett
added a commit
that referenced
this issue
Sep 21, 2021
MRG: Allow for delocating top level modules. This delocates libraries into one directory per wheel. I've added a top-level package-less wheel to test with. Prevents copying duplicate libraries when a wheel has multiple packages. Fixes #35. Fixes issues where the module to work on is at the top-level, such as a wheel with no packages. Generally any current issue where delocate mysteriously doesn't bundle libraries has been fixed. Fixes #72, fixes #22, fixes #45, fixes #63, fixes #121, fixes #66, fixes #49, fixes #67. See `_decide_dylib_bundle_directory` for how the folder to use is determined. I've followed the advice from #72 to use an auditwheel-style name. Wheels without packages use the folder `{package_name}.dylibs`, wheels with packages will put a `.dylibs` folder in only one of the packages preferring the one that matches the wheel name. The one directory will hold the dependencies of the entire wheel. After that the fix was simple: In `delocate_wheel` call `delocate_path` only once and call it with a `tree_path` that includes the entire wheel. Since this always collects everything regardless of if a package is found or not. This will also resolve issues where namespace packages couldn't be delocated. Fixes #95.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This bug report for auditwheel is probably also true of delocate:
pypa/auditwheel#89
The text was updated successfully, but these errors were encountered: