Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 0.7.4 broke travis build #40

Closed
dilawar opened this issue Oct 3, 2018 · 13 comments
Closed

Version 0.7.4 broke travis build #40

dilawar opened this issue Oct 3, 2018 · 13 comments

Comments

@dilawar
Copy link

dilawar commented Oct 3, 2018

The logs of build are here: https://api.travis-ci.org/v3/job/435219821/log.txt

I checked locally and could reproduce the error with python3.7. It failed due to following. Note sure if older version will also break with python3.7 .

ImportError: cannot import name 'open_for_csv' from 'wheel.util' (/Users/dilawars/Library/Python/3.7/lib/python/site-packages/wheel/util.py)
@dilawar dilawar changed the title Version 0.7.4 broken travis build Version 0.7.4 broke travis build Oct 3, 2018
@anthrotype
Copy link
Contributor

anthrotype commented Oct 3, 2018

master branch has a fix for that and other issues introduced by wheel 0.32.0
68355ee

Until new delocate is released and the dust settles I think it's better for you to pin wheel to 0.31.0

dilawar pushed a commit to BhallaLab/deploy that referenced this issue Oct 3, 2018
@matthew-brett
Copy link
Owner

I think you're picking up an old version of delocate - see the logs - you've got 0.7.3 ... You should not see the error with the new 0.7.4.

@dilawar
Copy link
Author

dilawar commented Oct 3, 2018

I think you're picking up an old version of delocate - see the logs - you've got 0.7.3 ... You should not see the error with the new 0.7.4.

I checked locally with 0.7.4 and 0.7.3 . Same error with both. Now I am using the older version of wheel as suggest by @anthrotype ; worked fine locally. Trying on travis now.

@matthew-brett
Copy link
Owner

@dilawar - could you post logs of your local testing? Here is me testing delocate 0.7.4 in a fresh virtualenv:

(test3) [brettmz@colles-12146 ~]$ pip install delocate
Collecting delocate
  Using cached https://files.pythonhosted.org/packages/09/53/a3c5680d223d4f8076da3ae646c8d7c36b70b9f027c482c75234db60e44c/delocate-0.7.4.tar.gz
Requirement already satisfied: wheel in ./.virtualenvs/test3/lib/python3.6/site-packages (from delocate) (0.32.0)
Building wheels for collected packages: delocate
  Running setup.py bdist_wheel for delocate ... done
  Stored in directory: /Users/brettmz/Library/Caches/pip/wheels/6f/60/4c/1ea0f3631bf8074eeaa6dae0be38b81150520a6301298e4235
Successfully built delocate
Installing collected packages: delocate
Successfully installed delocate-0.7.4
(test3) [brettmz@colles-12146 ~]$ python -c 'from delocate import delocate_wheel, __version__'
(test3) [brettmz@colles-12146 ~]$ pip install wheel==0.31.1
Collecting wheel==0.31.1
  Using cached https://files.pythonhosted.org/packages/81/30/e935244ca6165187ae8be876b6316ae201b71485538ffac1d718843025a9/wheel-0.31.1-py2.py3-none-any.whl
Installing collected packages: wheel
  Found existing installation: wheel 0.32.0
    Uninstalling wheel-0.32.0:
      Successfully uninstalled wheel-0.32.0
Successfully installed wheel-0.31.1
(test3) [brettmz@colles-12146 ~]$ python -c 'from delocate import delocate_wheel, __version__'
(test3) [brettmz@colles-12146 ~]$ 

This should also be tested in the delocate Travis-CI setup, but maybe I'm not doing it right.

@ezralanglois
Copy link

I see this issue also on travis:

Collecting delocate Using cached https://files.pythonhosted.org/packages/09/53/a3c5680d223d4f8076da3ae646c8d7c36b70b9f027c482c75234db60e44c/delocate-0.7.4.tar.gz Complete output from command python setup.py egg_info: error in delocate setup command: 'install_requires' must be a string or list of strings containing valid project/version requirement specifiers; Expected version spec in machomachomangler; sys_platform == 'win32' at ; sys_platform == 'win32'

@matthew-brett
Copy link
Owner

Ah yes - probably you're on Python 3.4? To fix, you need to update setuptools...

@ezralanglois
Copy link

Building Python 2.7.11

@matthew-brett
Copy link
Owner

Yes, still probably too-old setuptools.

@ezralanglois
Copy link

Yes, I can confirm that worked. Thanks!

@dilawar
Copy link
Author

dilawar commented Oct 5, 2018

Got fixed after deprecating wheel version to 0.31.0. Using latest delocate now. https://api.travis-ci.org/v3/job/437511577/log.txt

@dilawar dilawar closed this as completed Oct 5, 2018
@matthew-brett
Copy link
Owner

matthew-brett commented Oct 5, 2018

I still think that there is no error with Wheel 0.32.x and delocate 0.7.4 - but if you do generate such an error, please do send logs.

@dilawar
Copy link
Author

dilawar commented Oct 5, 2018

You are right. 0.7.4 works with wheel 0.32.1 (released yesterday). I havn't tested with 0.32.0 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants