Show recursive dependencies in listdeps command. #118
Conversation
HexDecimal
force-pushed
the
listdeps-recursive
branch
5 times, most recently
from
b6c6329 to
da602a0
Compare
|
I've changed the way the platform wheel is tested. No more The updated API understands that the external library can depend on libraries itself. So tests needed to be edited to include that extra information. |
|
Just checking quickly - this doesn't mean that we only test the code built on the platform on which we are testing? |
|
I haven't changed which platforms run tests. This still includes the tests that run without rebuilding the test data. I could now try running these tests in full isolation if you like.
|
delocate/libsana.py
Outdated
|
|
||
| start_path : iterable of str | ||
| Root path of tree to search for libraries depending on other libraries. | ||
| lib_filt_func : callable, optional |
There was a problem hiding this comment.
Comment as above about keyword only arguments.
delocate/libsana.py
Outdated
| executable_path : None or str, optional | ||
| If not None, an alternative path to use for resolving | ||
| `@executable_path`. | ||
| ignore_missing : bool, default=False |
There was a problem hiding this comment.
| ignore_missing : bool, default=False | |
| ignore_missing : bool, default=False, optional |
HexDecimal
force-pushed
the
listdeps-recursive
branch
2 times, most recently
from
829edae to
99c4673
Compare
Added tree_libs_from_directory function. This is an improved version of the tree_libs function. The wheel_libs function was modified to use tree_libs_from_directory. This is not fully backwards compatible since the new behavior will now raise an error instead of returning an incomplete lib dict.
Co-authored-by: Matthew Brett <matthew.brett@gmail.com>
Co-authored-by: Matthew Brett <matthew.brett@gmail.com>
HexDecimal
force-pushed
the
listdeps-recursive
branch
from
086a2c0 to
c2b9a61
Compare
Codecov Report
@@ Coverage Diff @@
## master #118 +/- ##
==========================================
+ Coverage 94.42% 94.76% +0.34%
==========================================
Files 13 13
Lines 986 994 +8
==========================================
+ Hits 931 942 +11
+ Misses 55 52 -3
Continue to review full report at Codecov.
|
|
Thanks - in it goes. |
I finally got around to updating listdeps.
Added the
tree_libs_from_directoryfunction instead of duplicating this code. This is an improved version of thetree_libsfunction.The
wheel_libsfunction was modified to usetree_libs_from_directory.This is not fully backwards compatible since the new behavior will now raise an error instead of returning an incomplete lib dict.
The listdeps test now moves the working directory to the test data dir to get more consistent results.
Closes #7