Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message for when a MacOS target version is not met #212

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

HexDecimal
Copy link
Collaborator

Adds clear instructions for how to update the MacOS target version when the current target is not met.

Closes #211

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.95%. Comparing base (526cc49) to head (8f155d6).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #212   +/-   ##
=======================================
  Coverage   96.95%   96.95%           
=======================================
  Files          15       15           
  Lines        1281     1282    +1     
=======================================
+ Hits         1242     1243    +1     
  Misses         39       39           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: Matthew Brett <matthew.brett@gmail.com>
Copy link
Owner

@matthew-brett matthew-brett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HexDecimal HexDecimal merged commit f6af445 into matthew-brett:master Mar 26, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DelocationError instead of automatically updating MacOS version of wheel
2 participants