Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use an extra to declare optional dependencies (currently,
sympy
) that are only used for the derivations.Currently,
sympy
is listed only as a test dependency intest-requirements.txt
, which isn’t completely accurate, since it’s used throughouttransforms3d.derivations
. However, it’s a fairly heavy-weight dependency, and isn’t needed at all for users that don’t need to import fromtransforms3d.derivations
. Adding the extra means that users who do plan to use derivations can depend ontransforms3d[derivations]
rather than having to add a direct dependency onsympy
.In the
python-transforms3d
package in Fedora, we currently deal with the use ofsympy
in the derivations by adding a weak dependency onsympy
to thepython3-transforms3d
package, but these weak dependencies still installed by default – andsympy
has its own weak dependency on a LaTeX environment, so all of TeXLive is pulled in. With aderivations
extra, we could drop the weak dependency and offer apython3-transforms3d+derivations
metapackage instead.