Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Promise for xray.then() #241

Merged
merged 3 commits into from
Jul 6, 2017
Merged

Conversation

kengz
Copy link
Contributor

@kengz kengz commented Dec 29, 2016

Add Promise for xray.then()

This solves the feature request for a promise, #62

  • Create a new method node.then(cb). Use the node.stream() method, create a promise from the stream, then invoke the then() with the callback cb.
  • add test
  • update documentation

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

@coveralls
Copy link

coveralls commented Dec 29, 2016

Coverage Status

Coverage decreased (-0.1%) to 95.775% when pulling dd57bb4 on kengz:master into bc5c173 on lapwinglabs:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 95.518% when pulling f444f4e on kengz:master into bc5c173 on lapwinglabs:master.

5 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 95.518% when pulling f444f4e on kengz:master into bc5c173 on lapwinglabs:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 95.518% when pulling f444f4e on kengz:master into bc5c173 on lapwinglabs:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 95.518% when pulling f444f4e on kengz:master into bc5c173 on lapwinglabs:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 95.518% when pulling f444f4e on kengz:master into bc5c173 on lapwinglabs:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 95.518% when pulling f444f4e on kengz:master into bc5c173 on lapwinglabs:master.

@kengz
Copy link
Contributor Author

kengz commented Dec 30, 2016

@matthewmueller I noticed there's a X-Ray In the Wild section in the Readme. FYI I used Xray to build this psi-scraper, feel free to include if u feel it's relevant, or it's okay not to as well.

@dougsilkstone
Copy link

Can we get this merged?

@kengz
Copy link
Contributor Author

kengz commented Mar 7, 2017

Is any of the authors available? This is ready to merge

@DannyCork DannyCork merged commit c2dadf6 into matthewmueller:master Jul 6, 2017
@taisang1996
Copy link

I have installed x-ray (2.3.2) by command npm install x-ray, but package do not have this feature.
Try install by command work well npm install https://github.com/matthewmueller/x-ray.

Please update this feature on npm.

@thebarty
Copy link

Plus one for mergin this in. Just lost some time on finding this solution. Thanks for the tip!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants