Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix promise compatibility #339

Merged
merged 3 commits into from
Jul 7, 2019
Merged

Fix promise compatibility #339

merged 3 commits into from
Jul 7, 2019

Conversation

leonardodino
Copy link
Contributor

@leonardodino leonardodino commented May 5, 2019 •
edited
Loading

Description

Fix Promise compatibility (allows use with async/await).

Currently, it's ignoring the second parameter, meaning it won't ever run catch blocks.

closes #62

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@leonardodino leonardodino mentioned this pull request May 14, 2019
Closed
@lathropd
Copy link
Collaborator

lathropd commented Jul 1, 2019

this needs a test case

@leonardodino
Copy link
Contributor Author

Rebased and added a test. (:

(I'm using it in production via async/await)

@lathropd lathropd merged commit d6fba8a into matthewmueller:master Jul 7, 2019
@leonardodino leonardodino deleted the fix-promise-then branch July 12, 2019 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add promise support
2 participants
@leonardodino @lathropd