Skip to content

Commit

Permalink
Rollup merge of rust-lang#97709 - compiler-errors:normalize-const-par…
Browse files Browse the repository at this point in the history
…am-ty, r=oli-obk

Normalize consts' tys when relating with `adt_const_params`

Fixes rust-lang#97007
  • Loading branch information
matthiaskrgr authored Jun 13, 2022
2 parents 083721a + 27af8e4 commit f773f1b
Show file tree
Hide file tree
Showing 2 changed files with 97 additions and 4 deletions.
13 changes: 9 additions & 4 deletions compiler/rustc_middle/src/ty/relate.rs
Original file line number Diff line number Diff line change
Expand Up @@ -579,10 +579,15 @@ pub fn super_relate_consts<'tcx, R: TypeRelation<'tcx>>(
debug!("{}.super_relate_consts(a = {:?}, b = {:?})", relation.tag(), a, b);
let tcx = relation.tcx();

// FIXME(oli-obk): once const generics can have generic types, this assertion
// will likely get triggered. Move to `normalize_erasing_regions` at that point.
let a_ty = tcx.erase_regions(a.ty());
let b_ty = tcx.erase_regions(b.ty());
let a_ty;
let b_ty;
if relation.tcx().features().adt_const_params {
a_ty = tcx.normalize_erasing_regions(relation.param_env(), a.ty());
b_ty = tcx.normalize_erasing_regions(relation.param_env(), b.ty());
} else {
a_ty = tcx.erase_regions(a.ty());
b_ty = tcx.erase_regions(b.ty());
}
if a_ty != b_ty {
relation.tcx().sess.delay_span_bug(
DUMMY_SP,
Expand Down
88 changes: 88 additions & 0 deletions src/test/ui/const-generics/issue-97007.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,88 @@
// check-pass

#![feature(adt_const_params, generic_const_exprs)]
#![allow(incomplete_features)]

mod lib {
const N_ISLANDS: usize = 4;
const N_BRIDGES: usize = 7;
const BRIDGES: [(usize, usize); 7] = [(0, 1), (0, 1), (0, 2), (0, 3), (0, 3), (1, 2), (2, 3)];

pub type Matrix = [[usize; N_ISLANDS]; N_ISLANDS];

const EMPTY_MATRIX: Matrix = [[0; N_ISLANDS]; N_ISLANDS];

const fn build(mut matrix: Matrix, (to, from): (usize, usize)) -> Matrix {
matrix[to][from] += 1;
matrix[from][to] += 1;
matrix
}

pub const fn walk(mut matrix: Matrix, from: usize, to: usize) -> Matrix {
matrix[from][to] -= 1;
matrix[to][from] -= 1;
matrix
}

const fn to_matrix(bridges: [(usize, usize); N_BRIDGES]) -> Matrix {
let matrix = EMPTY_MATRIX;

let matrix = build(matrix, bridges[0]);
let matrix = build(matrix, bridges[1]);
let matrix = build(matrix, bridges[2]);
let matrix = build(matrix, bridges[3]);
let matrix = build(matrix, bridges[4]);
let matrix = build(matrix, bridges[5]);
let matrix = build(matrix, bridges[6]);

matrix
}

const BRIDGE_MATRIX: [[usize; N_ISLANDS]; N_ISLANDS] = to_matrix(BRIDGES);

pub struct Walk<const CURRENT: usize, const REMAINING: Matrix> {
_p: (),
}

impl Walk<0, BRIDGE_MATRIX> {
pub const fn new() -> Self {
Self { _p: () }
}
}

impl<const CURRENT: usize, const REMAINING: Matrix> Walk<CURRENT, REMAINING> {
pub fn proceed_to<const NEXT: usize>(
self,
) -> Walk<NEXT, { walk(REMAINING, CURRENT, NEXT) }> {
Walk { _p: () }
}
}

pub struct Trophy {
_p: (),
}

impl<const CURRENT: usize> Walk<CURRENT, EMPTY_MATRIX> {
pub fn collect_prize(self) -> Trophy {
Trophy { _p: () }
}
}
}

pub use lib::{Trophy, Walk};

fn main() {
// Example, taking the first step
let _ = Walk::new().proceed_to::<1>();

// Don't be so eager to collect the trophy
// let trophy = Walk::new()
// .proceed_to::<1>()
// .proceed_to::<0>()
// .collect_prize();

// Can't just make a Trophy out of thin air, you must earn it
// let trophy: Trophy = Trophy { _p: () };

// Can you collect the Trophy?
}

0 comments on commit f773f1b

Please sign in to comment.