Skip to content

Commit

Permalink
Rollup merge of rust-lang#125224 - Oneirical:sixth, r=jieyouxu
Browse files Browse the repository at this point in the history
Migrate `run-make/issue-53964` to `rmake`

Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html).

This is extremely similar to rust-lang#125146. Could it be interesting to merge the two in some way? This one seems to do the same thing as the rust-lang#125146, but with an added check that a useless lint is not shown.
  • Loading branch information
matthiaskrgr authored May 23, 2024
2 parents b5d2bfa + dd7e68b commit ffc4d96
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 6 deletions.
1 change: 0 additions & 1 deletion src/tools/tidy/src/allowed_run_make_makefiles.txt
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,6 @@ run-make/issue-46239/Makefile
run-make/issue-47384/Makefile
run-make/issue-47551/Makefile
run-make/issue-51671/Makefile
run-make/issue-53964/Makefile
run-make/issue-64153/Makefile
run-make/issue-68794-textrel-on-minimal-lib/Makefile
run-make/issue-69368/Makefile
Expand Down
File renamed without changes.
File renamed without changes.
12 changes: 12 additions & 0 deletions tests/run-make/external-crate-panic-handle-no-lint/rmake.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
// Defining a crate that provides panic handling as an external crate
// could uselessly trigger the "unused external crate" lint. In this test,
// if the lint is triggered, it will trip #![deny(unused_extern_crates)],
// and cause the test to fail.
// See https://github.com/rust-lang/rust/issues/53964

use run_make_support::{rustc, tmp_dir};

fn main() {
rustc().input("panic.rs").run();
rustc().input("app.rs").panic("abort").emit("obj").library_search_path(tmp_dir()).run();
}
5 changes: 0 additions & 5 deletions tests/run-make/issue-53964/Makefile

This file was deleted.

0 comments on commit ffc4d96

Please sign in to comment.