Avoid unwanted ack #53
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The LMIC library is answering automatically to ACK DOWN request, with a dedicated message. It is no wanted to increase battery life, and the LoraWAN specification states that the ACK can wait next frame up. Furthermore, fCnt_up was not incremented despite a send message.
ngraziano
pushed a commit
to ngraziano/arduino-lmic
that referenced
this pull request
Feb 12, 2019
Correct ADR ACK request limit; fix matthijskooijman#53.
|
This repository is now deprecated, see #297 for some more background. I'm grateful for your contribution, but it will no longer be merged. I'm recommending people to use the MCCI version of LMIC instead. If this PR addresses an issue that also exists in that version, I would encourage you to resubmit your contribution there, so it might benefit other users. I'm sorry for the inconvenience... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LMIC library is answering automatically to ACK DOWN request, with a dedicated message.
It is no wanted to increase battery life, and the LoraWAN specification states that the ACK can wait next frame up.
Furthermore, fCnt_up was not incremented despite a send message.