Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the switch to
System.Text.Json
in #85 we can further improve TimeZoneNames for NativeAOT applications by switching to a source generatedTimeZoneData
JSON deserializer.Unfortunately
System.Text.Json
does not (yet) support init only properties, see dotnet/runtime#58770.For this draft I went with public setters, but alternatively a parameterized constructor should also work.
When I ran
DataBuilder
the order of the output changed, which I guess is either due non-stable dictionary sorting or that the CurrentCulture on my machine is a mix of en-US/en-GB and da-DK (reported as en-DK).I made a quick benchmark on calling
TimeZoneData.Load()
on .NET6 using Benchmarkdotnet which only focuses on the performance benefits of switching to a source generated JSON deserializer.Some stats on a
TimeZoneNames.NativeAot
application.main:
PR: