Ensure we're using the data view time field for the sort param too
#20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattkime
reviewed
May 8, 2024
| if (!timeFieldName) { | ||
| throw new Error('Invalid data view without timeFieldName.'); | ||
| if (!timeField) { | ||
| throw new Error(`Data view with ID ${index.id} no longer contains a time field.`); |
There was a problem hiding this comment.
Might as well add the name here but I guess I can do that
mattkime
merged commit b399fca
into
mattkime:search_source_query_fix
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the search source alert time field fix to also use the data view time field for the
sortparam, as well as adding a new error if the data view no longer has a time field.Checklist
For maintainers