Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement click / edit / delete callbacks #5

Closed
mattlewis92 opened this issue Jul 3, 2016 · 6 comments
Closed

implement click / edit / delete callbacks #5

mattlewis92 opened this issue Jul 3, 2016 · 6 comments
Labels
enhancement

Comments

@mattlewis92
Copy link
Owner

No description provided.

@gordon-to
Copy link
Contributor

This enhancement effects my project, i'm working on it now.

@mattlewis92
Copy link
Owner Author

Awesome, thanks! After some more thought on this I'd prefer this as the API as it allows greater flexibility + a smaller API surface: mattlewis92/angular-bootstrap-calendar#386 (comment)

@gordon-to
Copy link
Contributor

That would mean implementing the actions interface mattlewis92/calendar-utils#1

gordon-to added a commit to gordon-to/angular2-calendar that referenced this issue Jul 11, 2016
@gordon-to
feat: Added actions to events shown in slidebox
fa7ec3a 
Use CalendarEvent's EventAction interface to implement some events rendered on the monthview's
slidebox

fixes mattlewis92#5
@gordon-to gordon-to mentioned this issue Jul 11, 2016
Closed
@gordon-to
Copy link
Contributor

I'm not sure I like the way this works, I'd prefer to have a general callback for onEventClicked vs the actions array. Maybe in a tooltip actions would work.

@mattlewis92
Copy link
Owner Author

I think eventClicked should be it's own event (that fires when you click on the event title). The actions array should only be for edit / delete style of actions.

mattlewis92 pushed a commit that referenced this issue Jul 16, 2016
feat(monthView): add event actions
4fa11ea 
Half of #5, Closes #19
mattlewis92 pushed a commit that referenced this issue Jul 16, 2016
feat(monthView): add event clicked callback
e9816d2 
Part of #5
@mattlewis92
Copy link
Owner Author

Hi sorry about the late reply on this one, I've made a few small tweaks to your PR to put the actions on the same line as the event title but other than that LGTM. Thanks for the help! 👍

AndersTornkvist pushed a commit to AndersTornkvist/angular-calendar that referenced this issue Dec 29, 2020
feat(enableResizeStyling): make temporary resizing of the element opt…
4c59b05 
…-in by default so users can con

BREAKING CHANGE: the element will no longer have its styles changed by default when dragging and
resizing. You can now re-enable it by setting `[enableResizeStyling]="true"` on the element.

Closes mattlewis92#5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Added actions to events shown in slidebox gordon-to/angular2-calendar
2 participants
@gordon-to @mattlewis92