fix: check if event is cancelable before calling preventDefault (#132)

mattlewis92 · Dec 12, 2022 · 10bfc51 · 10bfc51
1 parent 73346e9
commit 10bfc51
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/.gitignore b/.gitignore
@@ -45,3 +45,4 @@ projects/angular-resizable-element/package.json
 # System Files
 .DS_Store
 Thumbs.db
+package-lock.json
diff --git a/projects/angular-resizable-element/src/lib/resizable.directive.ts b/projects/angular-resizable-element/src/lib/resizable.directive.ts
@@ -321,13 +321,8 @@ export class ResizableDirective implements OnInit, OnDestroy {
       this.mousemove
     ).pipe(
       tap(({ event }) => {
-        if (currentResize) {
-          try {
-            event.preventDefault();
-          } catch (e) {
-            // just adding try-catch not to see errors in console if there is a passive listener for same event somewhere
-            // browser does nothing except of writing errors to console
-          }
+        if (currentResize && event.cancelable) {
+          event.preventDefault();
         }
       }),
       share()