fix: check if event is cancelable before calling preventDefault #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattlewis92
reviewed
Dec 12, 2022
projects/angular-resizable-element/src/lib/resizable.directive.ts
Outdated
Show resolved
Hide resolved
mattlewis92
reviewed
Dec 12, 2022
.gitignore
Outdated
| @@ -45,3 +45,5 @@ projects/angular-resizable-element/package.json | |||
| # System Files | |||
| .DS_Store | |||
| Thumbs.db | |||
| package-lock.json | |||
| .gitignore | |||
There was a problem hiding this comment.
nit: can you remove the .gitignore from this file as we don't want it to ignore itself 😄
Codecov Report
@@ Coverage Diff @@
## main #132 +/- ##
==========================================
- Coverage 81.00% 80.93% -0.07%
==========================================
Files 5 5
Lines 279 278 -1
Branches 58 58
==========================================
- Hits 226 225 -1
Misses 42 42
Partials 11 11
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mattlewis92
changed the title
|
Released as |
|
Thanks Matt. Of course, I didn't think to look in the handle directive where there's another one for the mouseDown event. D'oh! I'll do another PR...I'm getting good at this now. :-D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Matt,
I've made the one-line change and I did check your automated tests run.
I didn't bother to create a branch. I don't normally bother as I work mostly alone and it's rare I work on code that isn't part of the core and needs to be in the next release anyway. Tell me if you'd rather I created a branch.
I will also confess I have not tested this by building it and using it in place of your npm library. This is down to time and the fact that this change is so simple. I hope you don't mind me not doing that - I would look at how to use it in place of an installed npm dependency for something more complex.
Over to you to accept or to bat back to me then...
Dan