Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to UV, enhance CI, and update dependencies #12

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

shauneccles
Copy link

Migrate the project to use UV for dependency management and build processes.

Update the CI configuration to test and build all supported python versions and include testing and build including build artifacts.

Clean up unnecessary dependencies and improve documentation, including optional plotting dependencies which would be installed when using statprocon[plot] via pip (once published).

ruff added and format used on codebase.

This is in prep for me to hopefully start adding additional chart types - uv is my preferred ecosystem.

@mattmccormick
Copy link
Owner

Hi Shaun, thanks so much for the contribution!

I was unavailable this past weekend and couldn't review. I won't likely get a chance to fully review until this weekend. I'm not familiar with uv and ruff and would like to review those first. Could you let me know - in your view, are these necessary to prep for additional chart types or a nice to have? From their websites it seems the main benefit is speed. Is there any other benefit?

It would be helpful if you could also provide an idea of what additional chart types you're looking to add going forward.

@shauneccles
Copy link
Author

shauneccles commented Jan 15, 2025

It's all a nice to have really.

uv reduces the cost/effort/energy in getting the project up to speed for new developers, and makes dependency management simpler and faster - acknowledge it's new but it's felt quite transformative for me and peojects I'm involved in.

ruff just standardises the codebase to something that is familiar and broadly used across the ruff/python ecosystem and can be used to lint and detect errors. Idea is to remove the variation in code styling and reduce parsing fatigue.

Main reason for the PR was to migrate onto modern infrastructure and add CI, for which UV and ruff are my chosen tools.

I'm about to move and move jobs but ideally at least c charts in the short term.

You can safely ignore the uv.lock file when reviewing - it's metadata about the locked dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants