Rework to support usage of encryption subkeys #247
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#238 (partly)
So, I've changed how public keys are managed in
EncryptionKeys
and how they are used in Encryption and some Verification inPGP
.Summary of the main changes in this PR:
PgpPublicKeyRingWithPreferredKey
(I'm still open for better name suggestions). This class stores the public key ring, the default key (using the already existing algorithm to find the 'best' key) and a preferred key, which can be set by the user usingEncryptionKeys.UseEncryptionKey(_some_keyId_)
I think more improvements can be made regarding the handling of public keys, but I think this PR could give an indication of a possible direction.