Swap JSON parser

[Matthew-Mosior]

This PR swaps out the JSON parser found in Language.JSON in contrib for @stefan-hoeck's parser-json (idris2-parser).

This also remove the dependency on contrib.

[mattpolzin]

The Makefile ought to run locally for you to save the round trip of GitHub CI running, though I don’t mind hitting the button to get it to run again.

[Matthew-Mosior]

The Makefile ought to run locally for you to save the round trip of GitHub CI running, though I don’t mind hitting the button to get it to run again.

I apologize, was fairly certain this Makefile would build.

I did make locally first and it built. Not sure what is going on here, but will get this fixed up.

[mattpolzin]

Without digging into the changes in much depth yet, my high level critique would be that I assume there's no reason we can't retain totality for those functions you've made partial so I'd like to do that since totality is such a nice guarantee. Even when I don't get totality I almost never opt for partial over covering (again because coverage checking is such a nice benefit offered by the compiler).

[Matthew-Mosior]

Without digging into the changes in much depth yet, my high level critique would be that I assume there's no reason we can't retain totality for those functions you've made partial so I'd like to do that since totality is such a nice guarantee. Even when I don't get totality I almost never opt for partial over covering (again because coverage checking is such a nice benefit offered by the compiler).

I agree with that, I'll re-work the partial functions so that they are at least covering.

[Matthew-Mosior]

@mattpolzin

I was able to rewrite the typeSpec function using substr in Prelude.Types instead of using the partial strTail function in Data.String, removing all of the partial annotations.

See 47e0188.

[Matthew-Mosior]

@mattpolzin

Not sure if you have time, but if this most recent commit doesn't build, would you mind taking a look at the Makefile? I'm sure I'm missing something silly (not a Makefile expert by any means).

[mattpolzin]

Sure. These days with pack around having a Makefile is kind of extra credit but I do want to maintain that because I’ve gone through the effort of making the project build without pack as a dependency. Happy to fix any remaining finicky details.

[Matthew-Mosior]

Sure. These days with pack around having a Makefile is kind of extra credit but I do want to maintain that because I’ve gone through the effort of making the project build without pack as a dependency. Happy to fix any remaining finicky details.

Awesome, thank you for helping with this!

[mattpolzin]

Thanks for taking the time to swap out contrib with Stefan's faster JSON library!

I'm still working through the combination of build & test failures as you can probably see but while I work on that there are some stylistic/preferential requests I have for you.

[mattpolzin]

I think we're there! Thanks again.

[Matthew-Mosior]

Thanks for taking the time to swap out contrib with Stefan's faster JSON library!

I'm still working through the combination of build & test failures as you can probably see but while I work on that there are some stylistic/preferential requests I have for you.

You're welcome, I'm glad that I am able to contribute!

Sounds good, see my commits below addressing your comments (you had great ideas/requests btw).

[Matthew-Mosior]

I think we're there! Thanks again.

Awesome, you're welcome!