Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mark anomalous metrics as such #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zmarcantel
Copy link

I added a bool field to the data.Datapoint struct that will say "yes, I am an anomaly".

This helps applications parse the output channel without creating a second channel that could potentially block if not properly/diligently read from. It also avoids a less-than-ideal strings.HasSuffix("anomalous") check.

I'm open to discussing other methods, but this seemed the easiest.

@mattrco
Copy link
Owner

mattrco commented Jul 22, 2014

Thanks for this. At the moment the three sigma analyzer has a separate output channel for anomalous values; is this insufficient for the use case you're thinking of?

I'm not opposed to merging this, just want to understand the use case better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants