Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update xcconfigs for Xcode 9 #151

Merged
merged 3 commits into from
Oct 11, 2017
Merged

Update xcconfigs for Xcode 9 #151

merged 3 commits into from
Oct 11, 2017

Conversation

mattrubin
Copy link
Owner

Updating the standard xcconfigs allows us to remove duplicate build settings from the xcodeproj.

@codecov
Copy link

codecov bot commented Oct 11, 2017

Codecov Report

Merging #151 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           develop    #151   +/-   ##
=======================================
  Coverage     94.7%   94.7%           
=======================================
  Files            6       6           
  Lines          378     378           
=======================================
  Hits           358     358           
  Misses          20      20

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98713ff...1e06e73. Read the comment docs.

@mattrubin mattrubin merged commit 93e8575 into develop Oct 11, 2017
@mattrubin mattrubin deleted the xcconfigs branch October 11, 2017 02:35
@mattrubin mattrubin added this to the 3.1 milestone Mar 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant