Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Generator validation #155

Merged
merged 10 commits into from
Mar 9, 2018
Merged

Refactor Generator validation #155

merged 10 commits into from
Mar 9, 2018

Conversation

mattrubin
Copy link
Owner

Convert Generator's failable initializer to a throwable initializer which rethrows validation errors.

@codecov
Copy link

codecov bot commented Dec 22, 2017

Codecov Report

Merging #155 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #155   +/-   ##
========================================
  Coverage    95.36%   95.36%           
========================================
  Files            6        6           
  Lines          475      475           
  Branches        33       34    +1     
========================================
  Hits           453      453           
  Misses          22       22
Impacted Files Coverage Δ
Sources/Generator.swift 100% <100%> (ø) ⬆️
Sources/Token+URL.swift 97.41% <100%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32818fd...852010d. Read the comment docs.

@mattrubin mattrubin merged commit 69b890a into develop Mar 9, 2018
@mattrubin mattrubin deleted the generator-errors branch March 9, 2018 03:21
@mattrubin mattrubin added this to the 3.1 milestone Mar 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant