Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SwiftLint configuration #159

Merged
merged 3 commits into from
Mar 8, 2018
Merged

Update SwiftLint configuration #159

merged 3 commits into from
Mar 8, 2018

Conversation

mattrubin
Copy link
Owner

@mattrubin mattrubin commented Mar 8, 2018

Enable more SwiftLint rules, adding a few targeted exceptions and fixing parameter alignment in several places.

Add a comment and temporarily disable the rule in one spot to prevent a false positive.
Add targeted exceptions for two long test functions.
@codecov
Copy link

codecov bot commented Mar 8, 2018

Codecov Report

Merging #159 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #159   +/-   ##
========================================
  Coverage    95.36%   95.36%           
========================================
  Files            6        6           
  Lines          475      475           
  Branches        33       33           
========================================
  Hits           453      453           
  Misses          22       22
Impacted Files Coverage Δ
Sources/Keychain.swift 87.23% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe0e35e...e2f3a06. Read the comment docs.

@mattrubin mattrubin merged commit 9a02087 into develop Mar 8, 2018
@mattrubin mattrubin deleted the lint branch March 8, 2018 22:38
@mattrubin mattrubin added this to the 3.1 milestone Mar 17, 2018
@mattrubin mattrubin changed the title Update SwifLint configuration Update SwiftLint configuration Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant