Keychain Deserialization Errors #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows persistentToken(withIdentifier:) and allPersistentTokens() to be refactored to not ignore deserialization errors.
Codecov Report
@@ Coverage Diff @@
## develop #161 +/- ##
===========================================
+ Coverage 95.36% 95.41% +0.04%
===========================================
Files 6 6
Lines 475 480 +5
Branches 34 32 -2
===========================================
+ Hits 453 458 +5
Misses 22 22
Continue to review full report at Codecov.
|
This was referenced Apr 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an internal throwing initializer for creating a Token from a url, and convert the failable initializer for creating a PersistentToken from a keychain dictionary to a throwing initializer.
This fixes an issue in
persistentToken(withIdentifier:)andallPersistentTokens()where deserialization errors would be ignored, causing a persistent token that existed but could not be deserialized to be treated the same as a persistent token that did not exist.