Quick fixes for Xcode 9.3 #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The underlying bug causing the false positive has been fixed in Swift 4.1
This rule is now catching many previously-missed violations. It may be enabled if the naming is cleaned up in the future.
New warnings in Swift 4.1 were breaking the ability to build the library via Carthage. (#166)
Codecov Report
@@ Coverage Diff @@
## develop #167 +/- ##
========================================
Coverage 95.41% 95.41%
========================================
Files 6 6
Lines 480 480
Branches 32 32
========================================
Hits 458 458
Misses 22 22Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in the Swift 4.1 compiler caused the build to break. (#166)
This PR:
SWIFT_COMPILATION_MODEbuild setting.disablecomment that was causing a SwiftLint error.identifier_namerule, which was catching many violations which it had previously missed.SWIFT_TREAT_WARNINGS_AS_ERRORStoNO, to let the build succeed despite several new deprecation warnings in Swift 4.1Fixes for the code deprecated by Swift 4.1 will follow in a future PR.