Synthesize Equatable conformance when compiling with Swift 4.1 #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #173 +/- ##
==========================================
+ Coverage 94.38% 97.19% +2.8%
==========================================
Files 6 6
Lines 392 392
==========================================
+ Hits 370 381 +11
+ Misses 22 11 -11
Continue to review full report at Codecov.
|
To reduce time spent waiting for the CI jobs, remove tests against the x.0 version of each major iOS version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use conditional compilation blocks to manually implement equality operators for Swift 4.0 and below, but use compiler-synthesized implementations for Swift 4.1 and above. Configure the CI to build with Xcode 9.3 (Swift 4.1) by default, but also add an extra CI build to explicitly test building with Xcode 9.0 (Swift 4.0).