Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SwiftLint configuration #187

Merged
merged 5 commits into from
Sep 14, 2018
Merged

Update SwiftLint configuration #187

merged 5 commits into from
Sep 14, 2018

Conversation

mattrubin
Copy link
Owner

@mattrubin mattrubin commented Sep 14, 2018

  • Remove an unnecessary explicit call to .init()
  • Enforce consistent modifier order
  • Clean up whitespace around colons

@@ -52,7 +52,7 @@ public final class Keychain {
// tokens as possible.
// TODO: Restore deserialization error handling, in a way that provides info on the failure reason and allows
// the caller to choose whether to fail completely or recover some data.
return Set(allItems.flatMap({ try? PersistentToken.init(keychainDictionary:$0) }))
return Set(allItems.flatMap({ try? PersistentToken(keychainDictionary:$0) }))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)

@mattrubin mattrubin merged commit 3b24612 into develop Sep 14, 2018
@mattrubin mattrubin deleted the lint branch September 16, 2018 00:09
@mattrubin mattrubin added this to the 3.1.4 milestone Sep 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants