Xcode 10 and Swift 4.2 #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of Xcode 10, the custom module maps are no longer needed.
As of Swift 4.1, these will be synthesized automatically.
As of March 27, 2019, the App Store requires submissions to be built with the iOS 12.1 SDK, which was first available in Xcode 10.1.
Codecov Report
@@ Coverage Diff @@
## develop #201 +/- ##
===========================================
+ Coverage 97.22% 99.34% +2.11%
===========================================
Files 6 6
Lines 397 153 -244
===========================================
- Hits 386 152 -234
+ Misses 11 1 -10
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## develop #201 +/- ##
===========================================
+ Coverage 97.22% 99.34% +2.11%
===========================================
Files 6 6
Lines 397 153 -244
===========================================
- Hits 386 152 -234
+ Misses 11 1 -10
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade the project to build with Xcode 10 and Swift 4.2.
As of March 27, 2019, the App Store requires submissions to be built with the iOS 12.1 SDK, which was first available in Xcode 10.1, so requiring Xcode 10 doesn't exclude any library users who weren't already unable to submit builds to the App Store.
Upgrading the Xcode and Swift version requirements allows the removal of: