Swift 5 compatibility (plus Swift 4.2 and 5 tests on Travis) #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, enable verbose logging when building with CocoaPods
Xcode 10.3 no longer supports the watchOS 2 simulator.
mattrubin
changed the title
Merged
Codecov Report
@@ Coverage Diff @@
## develop #215 +/- ##
===========================================
- Coverage 99.34% 97.17% -2.18%
===========================================
Files 6 6
Lines 153 389 +236
===========================================
+ Hits 152 378 +226
- Misses 1 11 +10
Continue to review full report at Codecov.
|
|
Codecov's indicated reduction in code coverage is entirely in files unmodified and unaffected by this PR, so I suspect the apparent change in coverage is due to a change in how Xcode generates coverage reports or how Codecov processes them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building off of The excellent work by @gereons in #209, this PR adds Swift 5 compatibility while maintaining Swift 4.2 compatibility, and manages to build and test the library with both Swift versions on Travis CI.