Update for Swift 3 #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add spaces between parameter names and arguments and remove extra newlines at the beginning of types.
Add code coverage reporting
Updating to recommended xcode 8 project settings
Update SwiftLint configuration
Update the note regarding keychain tests on iOS 10
Maintain one test with Xcode 7.3 and Swift 2.2
Update Travis configuration to use Xcode 8
Update Changelog for 2.0.1
Release OneTimePassword 2.0.1
houndci-bot
reviewed
Sep 20, 2016
| @@ -89,7 +88,7 @@ public struct Generator: Equatable { | |||
|
|
|||
| // Take 4 bytes from the hash, starting at the given byte offset | |||
| let truncatedHashPtr = ptr + Int(offset) | |||
| let truncatedHash = UnsafePointer<UInt32>(truncatedHashPtr).pointee | |||
| let truncatedHash = truncatedHashPtr.withMemoryRebound(to: UInt32.self, capacity: 1, { $0.pointee }) | |||
There was a problem hiding this comment.
Line Length Violation: Line should be 100 characters or less: currently 112 characters (line_length)
Current coverage is 91.64% (diff: 100%)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge in the latest changes from the Swift 2.3 branch, and update the code for compatibility with the Swift 3.0 release.
Fixes #85