Skip to content
This repository has been archived by the owner on Mar 24, 2021. It is now read-only.

Cleanup #9

Merged
merged 2 commits into from
May 31, 2020
Merged

Cleanup #9

merged 2 commits into from
May 31, 2020

Conversation

mattsch
Copy link
Owner

@mattsch mattsch commented May 31, 2020

  • Remove unused Nest auth params
  • Consolidate login
  • Add release-drafter bits back
  • Update docs to remove region requirements
  • Fixes #5

@mattsch mattsch added documentation Improvements or additions to documentation bug Something isn't working labels May 31, 2020
@mattsch mattsch merged commit 74f504f into master May 31, 2020
@mattsch mattsch deleted the bugfix/cleanup branch May 31, 2020 21:26
@evilavenger35
Copy link

Hi, quick question... is the ability to login with the legacy nest.com account gone after this commit... I've been unable to upgrade past v0.0.1, and haven't been able to troubleshoot. It appears to give the same error as with an access token problem, except for the last line, and refreshing the token does not make a difference.
thanks,
Mike

@mattsch
Copy link
Owner Author

mattsch commented Jun 10, 2020

Hi, quick question... is the ability to login with the legacy nest.com account gone after this commit... I've been unable to upgrade past v0.0.1, and haven't been able to troubleshoot. It appears to give the same error as with an access token problem, except for the last line, and refreshing the token does not make a difference.
thanks,
Mike

That functionality was gone since at least my intial merge to this repo. This PR just cleaned up old unused code.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix error handling
2 participants