Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GoFish Speed Improvements #14

Open
myearwood1 opened this issue Mar 17, 2022 · 18 comments
Open

GoFish Speed Improvements #14

myearwood1 opened this issue Mar 17, 2022 · 18 comments

Comments

@myearwood1
Copy link

I have techniques that are easy to implement and are by no means premature. People who always tell me "premature optimization" are clearly wrong. Obvious best practices are not premature optimization.

I'm running GoFish on a large project. Code is being executed over 200,000 times. I reworked the first few lines of Procedure SearchInTable and easily saved 5 seconds. One of those improvements alone was 600% better. Donald Knuth is often taken out of context with the premature optimization quote. He also said a 12% improvement would be accepted by all other industries except programmers.

@DougHennig
Copy link

As we've discussed before, you can either send me the changes and I'll incorporate them into the project, you can fork the project (although you have to fork the new one at https://github.com/VFPX/GoFish rather than this one since only Matt could merge into this repository and he sadly passed away) and do a pull request, or you can notify people about your fork.

@myearwood1
Copy link
Author

And what you seem to keep skipping over is there are a number of ignorant people in the FoxPro community who don't deserve to benefit from my best practices because they argue against them. They have made me very unwilling to contribute to a place where they can have it. No one did anything about it and when I stood up for myself I got removed from LevelExtreme and Foxite. I would therefore rather find a way that deserving individuals can get these improvements, or I will include the improvements with comments naming the individuals who don't deserve the code.

@myearwood1
Copy link
Author

For example - The darling of LevelExtreme allowed it to be believed that I and not she was the one that hacked into Andy Kramek's account. When I reported it to Michel Fournier, the person who made the accusation was banned, but Naomi was allowed to remain.
naomi

@DougHennig
Copy link

I won't merge any code "with comments naming the individuals who don't deserve the code". So, the only way to share the improvement with some people and not others is to make your fork private and email those people you want to share it with.

@myearwood1
Copy link
Author

Since I'm the one making the changes, what gives you any right to say what I can and cannot do? I should be in charge of it now, not you.

@myearwood1
Copy link
Author

Evil flourishes when good people do nothing and so many of the fox community allowed me to be bullied for YEARS.

@myearwood1
Copy link
Author

People could only complain about bugs, but offered no fixes. I offered a big fix to one bug, and no one bothered to check it in. Seems there was plenty of mismanagement around this project.

@myearwood1
Copy link
Author

The owners of LevelExtreme and Foxite can decide who is allowed in or not, so I can decide who uses my code or not. Not you.

@DougHennig
Copy link

This is really simple. Matt Slay passed away, so there is no one who can make any changes to this repository. Not me, not you. I have forked this repository at https://github.com/VFPX/GoFish. That is the one that is pointed to by the VFPX project list. So, you have two choices:

  • Make the changes in your own fork. If it's public, you have no way of preventing anyone from downloading it. If it's private, only those people you invite can access it.

  • Fork https://github.com/VFPX/GoFish and make the changes in that fork, then issue a pull request. As the administrator of that repository, I have every right to accept or reject any changes I see fit.

So, if you want to decide who uses your code, your own private fork is the only way to do it, or don't publish it/make it public at all.

@myearwood1
Copy link
Author

I will leave mine public and curse anyone I wish for their being ignorant and/or abusive and or overbearing censors.

@myearwood1
Copy link
Author

The community needs people who are capable and willing to donate their time. But that does not mean everyone is worth my time. It is my right to decide who I feel do not deserve it.

@myearwood1
Copy link
Author

I lost respect for lots of this "community" because they stood by and did nothing. I will make a better gofish and it will include complaints against the bad apples.

@myearwood1
Copy link
Author

I will be making either MyGoFish or GoFishX. I will not be censored nor commanded by those who never had my back.

@myearwood1
Copy link
Author

Go ahead Doug. Be the administrator of another example of poorly made code. Ignore the contributions of those who know how to do things properly. All too typical.

@myearwood1
Copy link
Author

@PatrickvonDeetzen
Copy link

GoFish5 with released speed improvements can be found here. 👍
https://github.com/VFPX/GoFish

@myearwood1
Copy link
Author

Fixed: When the results are shown and the order of the results is changed by clicking the header of column "Proccode", "Statement" or "Code" then the error "SQL: ORDER BY clause in invalid" was thrown. This was fixed by also excluding these columns in the functions "SortColumn" and "SortColumSecondary".

I made that fix YEARS ago, without removing any columns.

@myearwood1
Copy link
Author

myearwood1 commented Oct 11, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants