-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move dylib documentation closer to "Embedding Steel in Rust" section. #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Useful for browsing the "Built ins" which have many functions.
Useful for browsing the "Built ins" which have many functions.
wmedrano
changed the title
Move dylib closer to "Embedding Steel in Rust" section.
Move dylib documentation closer to "Embedding Steel in Rust" section.
Jan 18, 2024
2024-01-18 update: Converted back to draft until I get it working myself. |
When you say "get it working" do you mean getting dylibs working? |
Yes, doing my due diligence and actually following the guide. Edit as of 5 minutes ago, I seem to have it working. |
wmedrano
commented
Jan 19, 2024
wmedrano
commented
Jan 19, 2024
wmedrano
commented
Jan 19, 2024
Also add the dylibs feature since it is required.
Tested the instructions again and it seems to work. Anything else I can do to push this through? |
LGTM - thanks! |
mattwparas
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also relabels it as "Using Rust in Steel"
Demo: https://wmedrano.github.io/steel/book/start/dylib.html