Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move dylib documentation closer to "Embedding Steel in Rust" section. #143

Merged
merged 11 commits into from
Feb 1, 2024
Merged

Conversation

wmedrano
Copy link
Contributor

@wmedrano wmedrano commented Jan 18, 2024

Also relabels it as "Using Rust in Steel"

Demo: https://wmedrano.github.io/steel/book/start/dylib.html

@wmedrano wmedrano marked this pull request as ready for review January 18, 2024 13:33
@wmedrano wmedrano changed the title Move dylib closer to "Embedding Steel in Rust" section. Move dylib documentation closer to "Embedding Steel in Rust" section. Jan 18, 2024
@wmedrano wmedrano marked this pull request as draft January 19, 2024 03:13
@wmedrano
Copy link
Contributor Author

2024-01-18 update: Converted back to draft until I get it working myself.

@mattwparas
Copy link
Owner

When you say "get it working" do you mean getting dylibs working?

@wmedrano
Copy link
Contributor Author

Yes, doing my due diligence and actually following the guide.

Edit as of 5 minutes ago, I seem to have it working.

@wmedrano wmedrano marked this pull request as ready for review January 19, 2024 03:41
@wmedrano
Copy link
Contributor Author

wmedrano commented Feb 1, 2024

Tested the instructions again and it seems to work. Anything else I can do to push this through?

@mattwparas
Copy link
Owner

LGTM - thanks!

@mattwparas mattwparas merged commit 748156b into mattwparas:master Feb 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants