Support +inf.0 -inf.0 +nan.0 -nan.0 #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattwparas
reviewed
Feb 11, 2024
Comment on lines
178
to
183
| _ => { | ||
| self.depth -= 1; | ||
| let res = self.format_with_cycles(val, f); | ||
| self.depth += 1; | ||
| res | ||
| } |
There was a problem hiding this comment.
I'm having some trouble following this change - what was the purpose here?
There was a problem hiding this comment.
Redid this part, I think this is cleaner. I can also revert back to having to separate but similar functions.
- High level: format_with_cycles and top_level_format_with cycles seem to be very similar (difference) so tried to unify.
- Previously reviewed approach: Reused one of the functions when the special cases didn't match. But this means the depth was artificially increased a level. Probably doesn't matter but tried to keep the depth anyways.
- New approach - Pass an enum specifying which behavior to use.
There was a problem hiding this comment.
got it, I understand, I haven't looked at some of these functions in a long time 😄
mattwparas
approved these changes
Feb 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required storing a "next" token since
+inf.0was being parsed as 2 tokens:+andinf.0.Seems like this behavior is used to make creating addition functions easy like: