Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why do you not use json output for sat devices? #25

Closed
PhilipMay opened this issue Jun 17, 2022 · 2 comments
Closed

Why do you not use json output for sat devices? #25

PhilipMay opened this issue Jun 17, 2022 · 2 comments
Labels
enhancement New feature or request
Milestone
v2.0.1

Comments

@PhilipMay
Copy link
Collaborator

Hi,

for all but sat devices you use "json" output like this:

prometheus-smartctl/smartprom.py

Line 92 in 3fbd7bb

results = run(['smartctl', '-A', '-d', 'nvme', '--json=c', dev])

Why dont you use it for sat? Would that be an improvement?

prometheus-smartctl/smartprom.py

Line 61 in 3fbd7bb

results = run(['smartctl', '-A', '-d', 'sat', dev])

@ngosang ngosang added the enhancement New feature or request label Jul 27, 2022
@ngosang
Copy link
Collaborator

ngosang commented Jul 27, 2022

PRs are welcome!

@ngosang ngosang added this to the v2.0.1 milestone Jul 29, 2022
ngosang added a commit to ngosang/prometheus-smartctl that referenced this issue Jul 29, 2022
@ngosang
Add missing raw metrics for sat devices. Resolves matusnovak#25
869fe76
ngosang added a commit to ngosang/prometheus-smartctl that referenced this issue Jul 29, 2022
@ngosang
Add missing raw metrics for sat devices. Resolves matusnovak#25
b5127e4
@ngosang
Copy link
Collaborator

ngosang commented Jul 29, 2022

https://github.com/matusnovak/prometheus-smartctl/releases/tag/v2.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v2.0.1
Development

No branches or pull requests
2 participants
@PhilipMay @ngosang