Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "make test". Add Streem example file. #30

Merged
merged 2 commits into from
Dec 19, 2014
Merged

Fix "make test". Add Streem example file. #30

merged 2 commits into from
Dec 19, 2014

Conversation

practicalswift
Copy link
Contributor

No description provided.

@nickserv
Copy link
Contributor

👍 Not sure if we're sticking with .streem though.

@practicalswift
Copy link
Contributor Author

@nicolasmccurdy True, but that can easily be fixed later on if @matz decides so :-)

@practicalswift
Copy link
Contributor Author

I've now adding a commit to this PR which changes to the correct file extension (.strm) as per the decision made by @matz in issue #24.

@practicalswift
Copy link
Contributor Author

@matz Let me know if there is anything I can improve in this PR to make it merge-worthy :-)

@matz matz merged commit d79ad9f into matz:master Dec 19, 2014
matz added a commit that referenced this pull request Dec 19, 2014
…trm; #30

we should update tests more decriptive in the future.
alexispurslane pushed a commit to alexispurslane/streem that referenced this pull request Dec 20, 2014
…trm; matz#30

we should update tests more decriptive in the future.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants