pkg/private/common: remove NativeOrder and IsBigEndian

No longer needed. Native byte order is not often needed, but will eventually show up in standard library anyway (golang/go#57237).
matzf · Feb 3, 2023 · 346e06d · 346e06d
1 parent c9609c3
commit 346e06d
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 38 deletions.
diff --git a/pkg/private/common/BUILD.bazel b/pkg/private/common/BUILD.bazel
@@ -3,7 +3,6 @@ load("//tools/lint:go.bzl", "go_library", "go_test")
 go_library(
     name = "go_default_library",
     srcs = [
-        "binary.go",
         "defs.go",
         "errors.go",
     ],

diff --git a/pkg/private/common/binary.go b/pkg/private/common/binary.go
diff --git a/pkg/scrypto/rand.go b/pkg/scrypto/rand.go
@@ -16,6 +16,7 @@ package scrypto
 
 import (
 	"crypto/rand"
+	"encoding/binary"
 	mrand "math/rand"
 
 	"github.com/scionproto/scion/pkg/private/common"
@@ -38,7 +39,7 @@ func RandUint64() uint64 {
 		// OS, and there's nothing we can do about it.
 		panic("No random numbers available")
 	}
-	return common.NativeOrder.Uint64(b)
+	return binary.LittleEndian.Uint64(b)
 }
 
 // RandInt64 returns a random int64 value. The returned value can be negative.