-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] implement power low compression loss #18
base: master
Are you sure you want to change the base?
Conversation
6b2ca6f
to
0acfd8e
Compare
Whether modifying the loss function will improve performance |
Sorry my 1080ti is too weak. Could anybody with better hardware help me run the experiment? |
My own server is too slow. But it is found that the loss function is different from what the author said. Now just use the amplitude spectrum |
I have access to nvidia V100 GPUs, and I am currently training a modified version of this model. I can test this PR if you like |
@linzwatt That would be awesome! Thanks a lot |
hey @linzwatt any results? |
I am not sure if I ran it right -- I used the config as provided and I get this:
|
@kwikwag I think that its implementation is not following the formula of the paper, because in the second term I believe that it is not necessary to use torch.clamp (x, min = 0.0). Additionally the order of torch.pow and torch.abs is incorrect, following the formula you must first calculate torch.pow Another point is that to avoid gradient explosion, an episolon must be added in output and target_mag. |
fixed: #14
Still in progress, not yet tested. I have to wait until my initial run finish...