fix package for the upcoming 1.7 release #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mauro3
reviewed
Jul 1, 2021
src/base-traits.jl
Outdated
| @traitimpl IsBits{X} <- _isbits(X) | ||
|
|
||
| "Trait of all immutable types" | ||
| @traitdef IsImmutable{X} | ||
| Base.@pure _isimmutable(X) = !X.mutable | ||
| if VERSION >= v"1.7.0-DEV.1279" | ||
| Base.@pure _isimmutable(x) = !(x.name.flags & 0x2 == 0x2) |
There was a problem hiding this comment.
I don't follow. What is this about? I tried a quick search on julialang but no luck. Tnx!
There was a problem hiding this comment.
But actually, I think just using ismutabletype works.
There was a problem hiding this comment.
YOLO github edit...
mauro3
reviewed
Jul 1, 2021
mauro3
reviewed
Jul 1, 2021
|
You need to approve the workflow to run I think. |
|
👍 |
|
Thanks Kristoffer! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.