Implement GenerateUIDInRange method #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that we can assign correct ids to real human users: https://systemd.io/UIDS-GIDS/#special-distribution-uid-ranges GenerateUID can return 65536 because it just takes all users in /etc/passwd into account (even non-human ones). So it takes the "nobody" user (uid 65535) into account. Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
jimmykarily
changed the title
jimmykarily
commented
Jun 25, 2024
Comment on lines
+28
to
+29
| _, err = file.WriteString("foo:x:1001:1000:foo:/home/foo:/bin/bash\n") | ||
| _, err = file.WriteString("foo:x:1001:1000:foo:/home/foo:/bin/bash\n") |
There was a problem hiding this comment.
hm double line? That must have been a double-paste thingy.
jimmykarily
added a commit
to mudler/yip
that referenced
this pull request
Jun 26, 2024
and let them automatically set the uid and gid inside the "human" users range. Relevant: - mauromorales/xpasswd#3 - mudler/entities#15 Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
jimmykarily
added a commit
to mudler/yip
that referenced
this pull request
Jun 26, 2024
and let them automatically set the uid and gid inside the "human" users range. Relevant: - mauromorales/xpasswd#3 - mudler/entities#15 Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
jimmykarily
added a commit
to mudler/yip
that referenced
this pull request
Jun 26, 2024
and let them automatically set the uid and gid inside the "human" users range. Relevant: - mauromorales/xpasswd#3 - mudler/entities#15 Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
jimmykarily
added a commit
to mudler/yip
that referenced
this pull request
Jun 26, 2024
* Use variable that has "Name" assigned otherwise the user always appears as if it doesn't exist Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me> * Bump entities and xpasswd and let them automatically set the uid and gid inside the "human" users range. Relevant: - mauromorales/xpasswd#3 - mudler/entities#15 Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me> --------- Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
davidcassany
pushed a commit
to davidcassany/yip
that referenced
this pull request
Jul 3, 2024
* Use variable that has "Name" assigned otherwise the user always appears as if it doesn't exist Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me> * Bump entities and xpasswd and let them automatically set the uid and gid inside the "human" users range. Relevant: - mauromorales/xpasswd#3 - mudler/entities#15 Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me> --------- Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me> (cherry picked from commit d76f75c)
davidcassany
pushed a commit
to rancher/yip
that referenced
this pull request
Jul 8, 2024
* Use variable that has "Name" assigned otherwise the user always appears as if it doesn't exist Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me> * Bump entities and xpasswd and let them automatically set the uid and gid inside the "human" users range. Relevant: - mauromorales/xpasswd#3 - mudler/entities#15 Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me> --------- Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me> (cherry picked from commit d76f75c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so that we can assign correct ids to real human users:
https://systemd.io/UIDS-GIDS/#special-distribution-uid-ranges
GenerateUID can return 65536 because it just takes all users in /etc/passwd into account (even non-human ones). So it takes the "nobody" user (uid 65535) into account.