Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify major version of Android Support library #313

Closed
wants to merge 1 commit into from

Conversation

ihadeed
Copy link

@ihadeed ihadeed commented Jul 8, 2017

This fixes build issues when using other plugins that rely on Android Support Library

@albe
Copy link

albe commented Aug 22, 2017

Probably needs to be 23.+ since the plugin targets API level 23 in https://github.com/mauron85/cordova-plugin-background-geolocation/blob/master/android/plugin/build.gradle where this also needs to be applied.

Fixes #309

@mauron85
Copy link
Owner

mauron85 commented Oct 31, 2017

I'm very reserved to merge PR that change versions of libs. It might resolve your issue, but break for somebody else.

@mauron85
Copy link
Owner

mauron85 commented Oct 31, 2017

Let's wait when there will be enough people having same issue. Right know it seems that there is just you to be affected. Considering there is close to 5000 downloads a month it doesn't look like common issue.

@mauron85
Copy link
Owner

Notice: this issue has been closed because it has been reported for branch 2.x or later. It could be already fixed in v3 or is not relevant anymore. You may reopen this issue if it has been closed in error.

1 similar comment
@mauron85
Copy link
Owner

Notice: this issue has been closed because it has been reported for branch 2.x or later. It could be already fixed in v3 or is not relevant anymore. You may reopen this issue if it has been closed in error.

@mauron85
Copy link
Owner

Any attempt to lock version of dependencies will not be merged.
I know and understand that it will temporarily solve your problem.
But this is not maintainable solution. It might work for some of you, but others may require different versions.

If you need specific version of libraries, then go and fork this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants